This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] child_info::child_info: Fix a comment
- From: Corinna Vinschen <corinna at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 24 Jun 2016 21:39:14 -0000
- Subject: [newlib-cygwin] child_info::child_info: Fix a comment
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b87224fba54587141253fe960f1134dcda94ddc4
commit b87224fba54587141253fe960f1134dcda94ddc4
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Tue Dec 15 17:14:08 2015 +0100
child_info::child_info: Fix a comment
Diff:
---
winsup/cygwin/sigproc.cc | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index 4ebcb0a..60c931d 100644
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -776,13 +776,8 @@ child_info::child_info (unsigned in_cb, child_info_types chtype,
This seems to be a bug in Vista's WOW64, which apparently copies the
lpReserved2 datastructure not using the cbReserved2 size information,
but using the information given in the first DWORD within lpReserved2
- instead. 32 bit Windows and former WOW64 don't care if msv_count is 0
- or a sensible non-0 count value. However, it's not clear if a non-0
- count doesn't result in trying to evaluate the content, so we do this
- really only for Vista 64 for now.
-
- Note: It turns out that a non-zero value *does* harm operation on
- XP 64 and 2K3 64 (Crash in CreateProcess call).
+ instead. However, it's not clear if a non-0 count doesn't result in
+ trying to evaluate the content, so we do this really only for Vista 64.
The value is sizeof (child_info_*) / 5 which results in a count which
covers the full datastructure, plus not more than 4 extra bytes. This