This is the mail archive of the
cygwin-cvs@cygwin.com
mailing list for the Cygwin project.
[newlib-cygwin] Fix potential endless loop in pending_signals::clear
- From: Corinna Vinschen <corinna at sourceware dot org>
- To: cygwin-cvs at sourceware dot org
- Date: 3 Nov 2015 17:25:34 -0000
- Subject: [newlib-cygwin] Fix potential endless loop in pending_signals::clear
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=0ed1523470ba33a2afba1510a19e51c4af9e329a
commit 0ed1523470ba33a2afba1510a19e51c4af9e329a
Author: Corinna Vinschen <corinna@vinschen.de>
Date: Tue Nov 3 18:25:23 2015 +0100
Fix potential endless loop in pending_signals::clear
* sigproc.cc (pending_signals::clear): Fix previous fix resulting in
yet another endless loop.
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/ChangeLog | 5 +++++
winsup/cygwin/sigproc.cc | 13 ++++---------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index dfeaf39..b990d9f 100644
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,8 @@
+2015-11-03 Corinna Vinschen <corinna@vinschen.de>
+
+ * sigproc.cc (pending_signals::clear): Fix previous fix resulting in
+ yet another endless loop.
+
2015-11-02 Corinna Vinschen <corinna@vinschen.de>
* include/netinet/ip.h (MAX_IPOPTLEN): Define.
diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index fbc738d..6a7708f 100644
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -402,16 +402,11 @@ sig_clear (int sig)
void
pending_signals::clear (_cygtls *tls)
{
- sigpacket *q = &start, *qnext;
+ sigpacket *q, *qnext;
- while ((qnext = q->next))
- {
- if (qnext->sigtls == tls)
- {
- q->next = qnext->next;
- qnext->si.si_signo = 0;
- }
- }
+ for (q = &start; (qnext = q->next); q->next = qnext->next)
+ if (qnext->sigtls == tls)
+ qnext->si.si_signo = 0;
}
/* Clear pending signals of specific thread. Called from _cygtls::remove */