This is the mail archive of the cygwin-apps mailing list for the Cygwin project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Fix some errors which cause unnecessary rebases

From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
To: cygwin-apps at cygwin dot com
Date: Fri, 9 Feb 2018 20:52:00 +0100
Subject: Re: [PATCH 2/2] Fix some errors which cause unnecessary rebases
Authentication-results: sourceware.org; auth=none
References: <20180209115941.512448-1-jon.turney@dronecode.org.uk> <20180209115941.512448-3-jon.turney@dronecode.org.uk>
Reply-to: cygwin-apps at cygwin dot com

On Feb  9 11:59, Jon Turney wrote:
> Also add some parentheses for clarity

I'm not a friend of excessive bracketing, especially when the evaluation
order is unambiguous.  This also covers what this patch is *really* meant
to fix, so I'd prefer a patch with only the fix.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH rebase 0/2] Avoid unncessary rebases
  - From: Jon Turney
- [PATCH 2/2] Fix some errors which cause unnecessary rebases
  - From: Jon Turney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]