Re: [PATCH setup 0/4] Use a pop-up menu to select chooser view filter

[Jon Turney <jon dot turney at dronecode dot org dot uk>]

On 26/08/2016 09:07, Corinna Vinschen wrote:
> On Aug 25 15:34, Yaakov Selkowitz wrote:
> > On 2016-08-25 14:11, Jon Turney wrote:
> > > On 24/08/2016 17:50, Corinna Vinschen wrote:
> > > > One question: Usually the popup menu itself reflects the current choice.
> > > > So, wouldn't it make more sense to have the text "View" just as plain
> > > > text to the left, and the actual popup menu next right to it, showing
> > > > the current choice?  Yes?  No?  Shut up?
> > >
> > > Yeah, there is probably better visual language to be used here.
> > >
> > > If the popup menu itself reflects the current choice, perhaps we don't
> > > need a caption with the current choice at all (i.e. just a button that
> > > says "View" and that's all...)
> > >
> > > I'd really like that button to have a '▾' to indicate it has a
> > > drop-down, but that seems hard to achieve.
> > >
> > > (This might be done with the BS_SPLITBUTTON style (which combines a
> > > button and dropdown menu), but that is sadly only supported by common
> > > controls on Vista or later.)

Two more patches follow this mail, which do that.

I'm still not totally happy with this.  It could give the impression 
that something is supposed to happen when the "View" part of the the 
button is clicked, and there is no keyboard shortcut to open the view 
selection menu.

> > We're dropping Cygwin support for XP anyway, so why not from the installer
> > as well?
>
> ACK.

I guess so, if a splitbutton is the right solution.

Should this be done using ld flags --major-os-version 6 
--minor-os-version 0?  Or some sort of runtime check?