Re: setup

[Corinna Vinschen <corinna-cygwin at cygwin dot com>]

Hi Achim,

On Jun 11 23:03, Achim Gratz wrote:
> Achim Gratz writes:
> > I'll do that later since I have to re-shuffle some local commits and
> > then test everything again first.
> 
> Done.
> 
> > If you're so inclined you could perhaps have a look at the next commit
> > on my local branch:
> 
> The re-worked version including local compressed setup.ini files is
> available at:
> http://repo.or.cz/w/cygwin-setup/local.git/commitdiff/d289e1824d44b0e75115e2207770335b905183e0
> 
> I haven't tested signatures since I am not yet signing my own
> installations.  The chooser window now comes up almost instantaneously
> in chooser mode from "known good" local mirror even when getting the
> files over slow or congested network.

"known good" == -m?

Thank you for getting rid of IniParseFindVisitor :)

However, IniParseFindVisitor searched the tree for ini files, so, does
the new code still work for the standard local install with ini files
copied from various mirrors, w/o -m option?  It seems the answer is yes
(you're iterating over the site list), but it would be helpful if this
had been tested.

The patch is a bit big and mixes several things into one.  It would
be helpful for potential later blaming to split it into independent
chunks to commit separately.  E.g., in at least one instance you just
reordered a few lines without functional change.  This may better go
in as a separate style patch.

Otherwise it looks ok, but I'd be more comfortable to see the splitted
patches before ok'ing it.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

Attachment: pgpSEkreVgRBS.pgp
Description: PGP signature