This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH setup 4/4] Remove msg() from LogFile::endEntry()


Every single line of log output is written to OutputDebugString() using msg().
This makes setup run quite slowly under a debugger.  If you have stdout
connected to the terminal where your debugger is running (e.g. 'gdb setup'),
this output is duplicated.

Future work: there are some other uses of msg() to report real errors.  At the
moment, these are completely invisible unless you are running setup under a
debugger.  These should be converted to use the logger.

2015-03-02  Jon TURNEY  <jon.turney@dronecode.org.uk>

	* LogFile.cc (endEntry): Remove msg().

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
 LogFile.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/LogFile.cc b/LogFile.cc
index b45d38c..69bf70b 100644
--- a/LogFile.cc
+++ b/LogFile.cc
@@ -248,7 +248,6 @@ LogFile::endEntry()
    * non-0 memory on alloc
    */
   currEnt->msg += buf;
-  msg ("LOG: %d %s", currEnt->level, buf.c_str());
 
   /* reset for next use */
   theStream = new std::stringbuf;
-- 
2.1.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]