This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: GCC-4.7.2-2: Go/No-go?
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: cygwin-apps at cygwin dot com
- Date: Sun, 21 Apr 2013 06:20:21 +0100
- Subject: Re: GCC-4.7.2-2: Go/No-go?
- References: <51643F10 dot 7000905 at gmail dot com> <87eheixuz8 dot fsf at Rainer dot invalid> <20130410154730 dot GA404 at ednor dot casa dot cgf dot cx> <516599BE dot 7090000 at gmail dot com> <51661EA2 dot 1070801 at users dot sourceforge dot net> <51665212 dot 6050101 at gmail dot com> <51665F0F dot 8040902 at users dot sourceforge dot net> <5166AD45 dot 8080809 at gmail dot com> <516EF104 dot 7040508 at users dot sourceforge dot net>
On 17/04/2013 19:59, Yaakov (Cygwin/X) wrote:
> On 2013-04-11 07:32, Dave Korn wrote:
>> On 11/04/2013 07:58, Yaakov (Cygwin/X) wrote:
>>> Your boehm-gc patch can replace my java-libgc-win32.patch, provided it
>>> works properly.
>>
>> It appears to, libjava testsuite results are as good as they've
>> ever been,
>> although I don't know whether or not the testsuite checks the
>> invocation API.
>> It's certainly the more complete approach to take than just not
>> supporting
>> the register/unregister methods, as confirmed by the fact that upstream
>> boehm-gc has implemented it for Cygwin.
>
> There is a mistake in that patch. The DEBUG_CYGWIN_THREADS conditionals
> need to be "if", not "ifdef", as elsewhere in the same source file.
Oops, that was a cut'n'paste error when I copied the skeleton of those
functions from pthread_support.c, where #ifdef DEBUG_THREADS is the form to
use. Thanks for spotting it; fixed in my repo ready for next release.
cheers,
DaveK