This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ATTENTION: Tcl/Tk transition


On 12/4/2011 7:33 PM, Yaakov (Cygwin/X) wrote:
On Sat, 2011-12-03 at 18:45 -0500, Charles Wilson wrote:
Yaakov -- the installed tclConfig.sh and tkConfig.sh files include stuff
like this:

TCL_DEFS='-DPACKAGE_NAME=\"tcl\" -DPACKAGE_TARNAME=\"tcl\"
-DPACKAGE_VERSION=\"8.5\" -DPACKAGE_STRING=\"tcl\ 8.5\"
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 ....

This causes warnings (PACKAGE_NAME redefined, etc) when building other
packages.

Which packages are you referring to?

I found this while building (msys) versions of tcl and tk, (loosely) based on your cygports. However...I modified tk's configure.in to do a "proper" AC_INIT. So now, tk defines PACKAGE_NAME as "tk" -- but inherits tclConfig's setting of "tcl" (and etc.).


It's possible that because tk doesn't, OOB, use the proper AC_INIT invocation that you don't see this problem with your builds. But...is it really right for tk to self-identify as "tcl"?

Fix that...and then you see the warning.

However, it just seems unambiguously correct, to me, that derived packages should NOT inherit "tcl's" settings of those particular macros.

--
Chuck


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]