This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Fix a cosmetic problem when there are no packages to install
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Fri, 22 Jul 2011 16:12:16 +0200
- Subject: Re: [PATCH] Fix a cosmetic problem when there are no packages to install
- References: <20110424161351.GC23944@ednor.casa.cgf.cx> <1311339756-504-1-git-send-email-jon.turney@dronecode.org.uk>
- Reply-to: cygwin-apps at cygwin dot com
On Jul 22 14:02, Jon TURNEY wrote:
> My previous patch introduces a cosmetic problem when there are no packages
> to install.
>
> Calling ThreeBarProgressPage::SetBar2(0, 0) indicates we are -2147483648%
> done, while we iterate over all packages looking for packages to md5sum.
>
> So avoid calling SetBar2() in that case.
>
> 2011-07-21 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * install.cc (do_install_thread): Fix cosmetic problem when
> there are no packages to install.
Go ahead. Just change your ChangeLog entry to something more
descriptive, like, say, "Only set progress bar output if at least
one package gets installed."
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat