This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: setup and mintty (was Re: New setup.exe release?)
On May 24 13:25, Christopher Faylor wrote:
> On Tue, May 24, 2011 at 11:50:52AM +0200, Corinna Vinschen wrote:
> >On May 24 11:15, Corinna Vinschen wrote:
> >> On May 23 21:14, Andy Koppe wrote:
> >> > On 23 May 2011 12:50, Corinna Vinschen wrote:
> >> > > And who's going to create the patches?
> >> >
> >> > I suppose that should be me, but my spare time is rather limited at
> >> > the moment and I still owe a patch or two for other things.
> >>
> >> I'm just trying a setup.exe patch which creates "Cygwin Terminal"
> >> desktop and start menu entries which point to "mintty -". I just
> >> have to get rid of my build environment problems...
> >
> >Ok, here's my patch. It just replaces the Desktop and Start Menu
> >entries with "Cygwin Terminal" entries pointing to "mintty -" and
> >leaves Cygwin.bat untouched. Is that ok with everyone?
> >
> >Index: desktop.cc
> >===================================================================
> >RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
> >retrieving revision 2.55
> >diff -u -p -r2.55 desktop.cc
> >--- desktop.cc 19 Nov 2010 15:49:54 -0000 2.55
> >+++ desktop.cc 24 May 2011 09:47:51 -0000
> >@@ -78,7 +78,8 @@ DesktopSetupPage::DesktopSetupPage ()
> > static void
> > make_link (const std::string& linkpath,
> > const std::string& title,
> >- const std::string& target)
> >+ const std::string& target,
> >+ const std::string& arg)
> > {
> > std::string fname = linkpath + "/" + title + ".lnk";
> >
> >@@ -93,10 +94,10 @@ make_link (const std::string& linkpath,
> > std::string exepath;
> > std::string argbuf;
> >
> >- if (!is_legacy)
> >+ if (IsWindowsNT ())
>
> Why the change from is_legacy?
Testing is_legacy was wrong here. The else branch using command.com
is for 9x only. YOu won't want that for NT, independently whther you
install the old or the new Cygwin.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat