This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 6/6] Handle short reads in archive_tar_file::read()
On 21/04/2011 11:07, Jon TURNEY wrote:
> On 20/04/2011 17:40, Corinna Vinschen wrote:
>> On Apr 8 15:43, Jon TURNEY wrote:
>>> archive_tar_file::read() currently considers any short read an error.
>>>
>>> These can now occur if the underlying bz2 compressed io_stream starts a
>>> new compression stream in the middle of the read
>>>
>>> It also transparently reads to the next 512-byte block in the parent
>>> io_stream after reading all the data expected for a file.
>>>
>>> Teach it to do things correctly, even if a short read occurs.
>>>
>>> 2011-04-08 Jon TURNEY <...>
>>>
>>> * archive_tar_file.cc (read): Handle short reads
>>
>> Same here. I guess it goes without saying that you tested it...
>
> I've tested that a few randomly chosen existing packages can be installed, as
> well as testing that pbzip2 compressed packages can be installed.
>
> I suppose I ought to be more exhaustive and check that all current packages
> can be installed, let me see if I can find a day or two to do that...
Ok, I've tested that all current packages install successfully with this
change, so I've applied patches 5 & 6.
For convenience, I have generated a snapshot at [1]
[1] http://cygwin.com/setup/snapshots/setup-2.747.exe