This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH 3/3] Add the last element of URL path to site chooser, if interesting.
On 22/11/2010 13:03, Jon TURNEY wrote:
> On 19/11/2010 17:13, Corinna Vinschen wrote:
>> On Nov 19 11:07, Christopher Faylor wrote:
>>> On Sat, Nov 06, 2010 at 05:05:15PM +0000, Jon TURNEY wrote:
>>>> Currently, if, for example, I manually add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/
>>>> to setup's mirror list, I get two indistinguishable entries named http://mirrors.kernel.org.
>>>>
>>>> Furthermore, because the code to ensure the site just added is selected uses the string inside the list control
>>>> to locate elements, we end up with a random one of those two indistinguishable entries selected (usually the
>>>> previously existing one). This problem also prevents the selected sites being correctly saved and restored
>>>> for the next setup run.
>>>>
>>>> So, to make the site chooser list entries unique and distinguishable, add the last element of the URL path to
>>>> the site chooser, if it exists and isn't 'cygwin' (or some other alternatives used by current mirrors)
>>>>
>>>> (Also fix the logic for identifying protocol and site name part of the URL to find the first '/' after a '//',
>>>> rather than the first '/' after a '.', to handle sitenames which aren't FQDNs correctly)
>>>>
>>>> 2010-11-06 Jon TURNEY <jon.turney-GrJqePx9RPPAJUdA+FbntA-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org>
>>>>
>>>> * site.cc (init): If interesting, Show the last element of URL, as well
>>>> as the protocol and sitename in the site chooser
>>>
>>> I like this better than my idea of showing the full URL. Unless there
>>> are objections (Corinna?) please check in.
>>
>> No objections. Just go ahead.
>
> I've committed patches #1 and #2.
Oh yes, I meant to ask if there is a process for making setup snapshots.
The probability that I've broken something with all this fiddling is non-zero,
so it would be nice to get some testing, if possible.