This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] inform user if any postinstall script failed to run


On 12 August 2010 15:03, Christopher Faylor wrote:
> On Thu, Aug 12, 2010 at 12:26:33PM +0200, Corinna Vinschen wrote:
>>On Aug 12 11:10, Jon TURNEY wrote:
>>> On 12/08/2010 06:44, Andy Koppe wrote:
>>> >Shall we tone down the error box here a little bit? A postinstall
>>> >failure in some obscure package that might only have been installed
>>> >due to the user selecting 'All' won't actually impact on the use of
>>> >Cygwin. I think the current wording will unnecessarily scare off
>>> >unexperienced users who wouldn't know how to correct these failures.
>>> >
>>> I agree, I was going to suggest something like this. ÂI'm afraid I
>>> just copied and adjusted the text from the dependencies declined
>>> dialog.
>>>
>>> It might be better to point to setup.log.full since it seems that
>>> contains the actual output from the failing command, and only from
>>> the most recent run of setup.
>>
>>Yes, that sounds like a good idea to me.
>
> I think that wording will still cause consternation.
>
> Maybe we need something like:
>
> "This does not necessarily mean that the affected package will fail to
> function properly but if you do notice problems please check
> /var/log/setup.log.full ."

How about removing the popup box and amending the postinstall results
page along those lines?

Andy


Index: postinstallresults.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/postinstallresults.cc,v
retrieving revision 1.1
diff -u -r1.1 postinstallresults.cc
--- postinstallresults.cc       29 Jul 2010 13:09:04 -0000      1.1
+++ postinstallresults.cc       12 Aug 2010 17:52:09 -0000
@@ -54,15 +54,6 @@
 long
 PostInstallResultsPage::OnNext ()
 {
-  // one or more postinstall scripts failed to run successfully
-  // installation may be broken
-  MessageBox (NULL,
-              "You will need to investigate and correct these errors "
-              "before your Cygwin installation will function properly.\n"
-              "Check setup.log for details.",
-              "ERROR - postinstall scripts failed",
-              MB_OK | MB_ICONERROR | MB_SETFOREGROUND | MB_TOPMOST);
-
   return IDD_DESKTOP;
 }

Index: res.rc
===================================================================
RCS file: /cvs/cygwin-apps/setup/res.rc,v
retrieving revision 2.88
diff -u -r2.88 res.rc
--- res.rc      6 Aug 2010 18:56:12 -0000       2.88
+++ res.rc      12 Aug 2010 17:52:10 -0000
@@ -433,7 +433,10 @@
     ICON            IDI_CYGWIN,IDC_HEADICON,SETUP_HEADICON_X,0,21,20
     LTEXT           "Postinstall script errors",IDC_STATIC_HEADER_TITLE
                     ,7,0,258,8,NOT WS_GROUP
-    LTEXT           "The following errors occured executing
postinstall scripts",
+    LTEXT           "Affected packages and those depending on them may not "
+                    "work correctly.\n"
+                    "If you notice problems please check "
+                    "/var/log/setup.log.full.",
                     IDC_STATIC,21,9,239,16,NOT WS_GROUP
     EDITTEXT        IDC_POSTINSTALL_EDIT,7,41,303,124,WS_VSCROLL | WS_HSCROLL |
                     ES_LEFT | ES_MULTILINE | ES_READONLY | ES_AUTOHSCROLL |


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]