This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] Stop automatic dependency selection on setup.exe chooser screen
- From: Corinna Vinschen <corinna-cygwin at cygwin dot com>
- To: cygwin-apps at cygwin dot com
- Date: Fri, 6 Aug 2010 18:00:37 +0200
- Subject: Re: [PATCH] Stop automatic dependency selection on setup.exe chooser screen
- References: <AANLkTileEcuy80itJgpZxn0R_X-Uio2eHjV5BLLphHXO@mail.gmail.com> <20100723031137.GA1475@ednor.casa.cgf.cx> <AANLkTindzUKOzf0Ajp2B6aw9MqM9Ncl1VQVu-0ehtOry@mail.gmail.com> <20100723045931.GB1475@ednor.casa.cgf.cx> <AANLkTi=RdUPM+k4oC_=iYoAVSGcZOM=7rft4Y++4+yi8@mail.gmail.com> <20100806133325.GB22459@ednor.casa.cgf.cx>
- Reply-to: cygwin-apps at cygwin dot com
On Aug 6 09:33, Christopher Faylor wrote:
> On Fri, Aug 06, 2010 at 01:25:54PM +0100, Andy Koppe wrote:
> >On 23 July 2010 05:59, Christopher Faylor wrote:
> >> Andy Koppe wrote:
> >>> [disable instant dependency updates and rely on resolver page instead]
> >>
> >> Now we get to find the bug reports hiding behind this bug.
> >
> >Found one, and it's big. The dependency resolver page only adds direct
> >dependencies of packages that have been selected, not indirect ones,
> >so you end up with missing DLLs. (They do get added before the package
> >selection screen if you run setup.exe again.)
> >
> >I obviously didn't test this properly. Andrew, please remove the gold
> >star I got for this.
>
> Before I back this out does anyone want to take a stab at fixing it?
> I'd do it but I have a couple of priority projects at work right now.
I'm looking into it, but it's tricky for people not quite up to speed
with STL. Basically the elements in unmap also have to be tested for
unsatisfied dependencies. One problem is that unmet is a map, so, when
adding elements to unmet, there has to be some marker which allows to
recognize elements which already have been tested for dependencies,
otherwise it will be rather slow.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat