Re: [ITP] makeself-2.1.5

[Steven Monai <steve+cygwin at monai dot ca>]

On 2010/04/10 8:58 AM, d.sastre.medina@gmail.com wrote:
> Packages are be available from:
> http://eco-lution.tv/cygwin/release/makeself/makeself-2.1.5-1-src.tar.bz2
> http://eco-lution.tv/cygwin/release/makeself/makeself-2.1.5-1.tar.bz2
> http://eco-lution.tv/cygwin/release/makeself/setup.hint
> 
> Although I stuck to http://cygwin.com/setup.html to prepare this, and
> to me it looks OK, please let me know if the packaging is incorrect, 
> some file is missing, etc...

I had a look at the above tarballs. My critique:

The src tarball contains just the upstream source with 'setup.hint'
added. It does not include a build script, so it is not clear how the
binary package tarball was built.

Ideally the src tarball contents should include at least the following:
(1) the unmodified upstream source, and
(2) a build script (a shell script, or a .cygport, or something similar)
that creates the source and binary tarballs from the upstream source.

As it stands currently, the src package is not acceptable.

The binary tarball looks mostly okay. However, it is missing the
Cygwin-specific document, which should be named:
usr/share/doc/Cygwin/makeself.README

The 'setup.hint' looks okay, although it includes a "curr:" line which
is unnecessary and should be removed.

Best regards,
-SM
--