This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
genini - one more...
- From: Charles Wilson <cygwin at cwilson dot fastmail dot fm>
- To: Mailing List: CygWin-Apps <cygwin-apps at cygwin dot com>
- Date: Sun, 14 Mar 2010 13:34:45 -0400
- Subject: genini - one more...
requires: is a required field in setup.hint files. I imagine this is to
force package maintainers to actively think about requirements; if they
want to specify 'none' then they have to actively assert it with an
'empty' requires:
requires:
However, setup.exe does NOT like empty requires: lines in the setup.ini
file. So, upset (and genini until revision 1.9, 2010/03/02) check that
requires is *present* in every setup.hint, but if the contents are
*empty*, then they did not put a matching empty requires spec into the
setup.ini file.
The following patch restores the previous behavior: setup.ini should
never contain
keyword: <nothing>
because setup.exe's parser will reject constructs like that.
2010-03-14 Charles Wilson <...>
* genini: Don't add keywords with no value to setup.ini
--
Chuck
Index: genini
===================================================================
RCS file: /cvs/cygwin-apps/genini/genini,v
retrieving revision 1.11
diff -u -p -r1.11 genini
--- genini 12 Mar 2010 18:57:05 -0000 1.11
+++ genini 14 Mar 2010 17:34:29 -0000
@@ -68,7 +68,7 @@ for my $p (sort keys %pkg) {
unless $main::categories{lc $c};
}
}
- print "$key: ", $val, "\n" if defined($val);
+ print "$key: ", $val, "\n" if defined($val) and $val ne "";
}
}
for my $what ('', "[prev]\n", "[test]\n") {