Re: Setup.exe - search for package

[Dave Korn <dave dot korn dot cygwin at googlemail dot com>]

Andrew Punch wrote:

> So I have come up with a patch which does that. It needs some tidying up
> but it is already functional.
> 
> The functionality I propose is as follows:
> * In the "Select Packages" screen I added a new edit box - the search
> edit box. The search edit box is to the left of the Keep/Prev/Curr/Exp
> and View elements
> * As soon as the text in the search edit box changes - the list of
> packages is filtered
> * If the package name contains the text in the search edit box - the
> package is displayed
> * If the View is "Category" when the text in the search edit box changes
> - the View is changed to "Full"
> * If the View is NOT "Category" when the text in the search edit box
> changes - the View is NOT changed
> * If the View is manually changed to "Category" - the text in the search
> edit box is erased

  This sounds like a perfectly reasonable approach to me.  Others might have
some input on the UI elements but it sounds useable.  I think it would be
slightly nicer if it filtered the tree-view rather than jumping to full mode,
but we could maybe do that afterward, as an enhancement, if it matters enough.

> Does anyone have any input before I tidy up the code and submit a patch?

  Yes:  Thank you!  That's all.

> Also I assume the cygwin-patches list is the correct place for the patch?

  No, please send it here, we always do setup.exe development on the -apps
list.  The -patches list is for patches to the winsup module, setup lives in a
whole different repository.

    cheers,
      DaveK