This is the mail archive of the cygwin-apps mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, As promised in <http://cygwin.com/ml/cygwin/2006-05/msg00612.html>, here's a patch that makes setup always draw the chooser icons using the system foreground and background colors (just like it does for text). I've also taken the opportunity to do a slight bit of code clean-up. There's still a little glitch left -- when doing a lot of fast scrolling back and forth, the icons sometimes switch from the system foreground color to the inverted system background color. I think I know why this is happening (i.e., the FillRgn() gets ignored for some reason), but this needs further debugging. As this is a corner case, I wouldn't worry too much about it. As always, the ChangeLog is below -- opinions welcome. Igor ChangeLog: ============================================================================== 2006-05-23 Igor Peshansky <pechtcha@cs.nyu.edu> * PickPackageLine.h (PickPackageLine::DrawIcon): Move to PickView. * PickView.h (PickView::DrawIcon): Move from PickPackageLine. * PickCategoryLine.cc (PickCategoryLine::paint): Use PickView::DrawIcon() instead of BitBlt(). * PickPackageLine.cc (PickPackageLine::DrawIcon): Move to PickView. (PickPackageLine::paint): Use PickView::DrawIcon(). * PickView.cc (PickView::~PickView): Delete GDI objects. (PickView::DrawIcon): New function. Use system default colors to draw bitmaps. (PickView::paint): Set background color instead of using transparent mode. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha@cs.nyu.edu | igor@watson.ibm.com ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte." "But no -- you are no fool; you call yourself a fool, there's proof enough in that!" -- Rostand, "Cyrano de Bergerac"
Attachment:
setup-bitmap-colors.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |