This is the mail archive of the
cygwin-apps
mailing list for the Cygwin project.
Re: [PATCH] setup: fix abnormal exit test for postinstall scripts
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Igor Peshansky wrote:
> On Thu, 16 Mar 2006, Max Bowsher wrote:
>
> Speaking of in-use DLLs, did you have a chance to look at
> <http://cygwin.com/ml/cygwin-apps/2006-03/msg00060.html>?
OK, I'll have a look.
>> So, I think we should always rename preremove scripts, because we
>> certainly don't want a failed preremove script to be removed by the
>> later file-removal phase - it might be wanted for debugging.
>
> I would even go one step further, and cancel the uninstall of the current
> package and all packages it depends on if the preremove failed. But
> that should be a separate patch.
>
>> As for postinstall scripts ... I think ideally it would be a separate
>> operation (c.f. 'dpkg --configure --pending'), but I guess we can go
>> with the simple solution for now, and defer a more complex solution
>> until someone has the inclination.
>
> So, does this mean "please check in"?
I'd like preremove scripts to be renamed on failure. But, OK, you check
in as-is, and I'll follow-up with a change for that.
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.1 (Cygwin)
iD8DBQFEGpFbfFNSmcDyxYARAkJVAJ4kDwP9yUuwcDLwwYNGiLzoXKt1EACgzJIk
BjR25ByI8bMaFEEeL9yOECw=
=fdn7
-----END PGP SIGNATURE-----