This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup: replace radiobuttons on chooser


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dave Korn wrote:
> 
>   Hi all, here's my contribution to the current setup patchfrenzy!
> 
>   The radiobuttons for Prev, Keep, Curr, Exp at the top of the package chooser
> should never have been radiobuttons.  They don't select a persistent mode,
> they perform an instantaneous action.  Action buttons should be pushbuttons.
> Hence this patch changes them to pushbuttons.

They seem to have BOTH an instantaneous AND a persistent influence,
actually - so I'd prefer to keep using controls which display the
current state.

>   Also, the view button with the cycling every time you click it thing?  Eww!
> :-P
> 
>   So I made it a combo box.  Now you can switch straight from one view to
> another without stepping through the ones you didn't want to see first.  I
> think that's more windows-UI-y-ish, IYSWIM.

Thankyou thankyou thankyou!

I don't suppose you feel like separating these two elements into
individual patches?

If not, I'll do it.


Thanks,
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFEFuk9fFNSmcDyxYARAtc3AKDRct1+jm6pE5UKAfLKcsz3xPxVFQCgkKhH
yMdgNdhKUVdog8QdzWGyEMI=
=KYuM
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]