This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] setup: fix abnormal exit test for postinstall scripts


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Igor Peshansky wrote:
>> 2006-01-23  Igor Peshansky  <pechtcha@cs.nyu.edu>
>>
>> 	* script.cc (Script::run): Fix inverted test for abnormal exit.
> 
> Ping (attached as "setup-script-exit-code-fix.patch-1").

Clearly correct, please commit.



>> 2006-01-31  Igor Peshansky  <pechtcha@cs.nyu.edu>
>>
>> 	* script.cc (Script::run): Fix inverted test for abnormal exit.
>> 	Do not rename to ".done" unless completed successfully.
> 
> And ping (attached as "setup-script-exit-code-fix.patch").

Do we necessarily want to try to re-run failed scripts the next time
setup installs some packages?

Perhaps renaming to ".failed" would be better that not renaming.

Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)

iD8DBQFEELa2fFNSmcDyxYARAtZgAKCMt94Mi7e30wXEBuVWFMiKPmn5IwCghUTV
zlM8FB3Pj9Ka7DMKsMG7F44=
=dpUu
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]