This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [g-b-s Patch] Write and save logfiles for configure/make/check/install


On Sun, 9 Oct 2005, Dr. Volker Zell wrote:

> >>>>> Igor Pechtchanski writes:
>
> > Also, please make sure your ChangeLog is formatted properly, and please
> > attach the patch instead of including it inline.
>
> Ok, here it is.
>
> 2005-09-10  Dr. Volker Zell  <dr dot volker dot zell at oracle dot com>
>
> 	* templates/generic-build-script (log_pkg_name): New.
> 	(configurelogfile): New.
> 	(makelogfile): New.
> 	(checklogfile): Name change.
> 	(installlogfile): New.

FYI, this could be compressed:

	(configurelogfile,makelogfile,installlogfile): New.

> 	(conf): Add logging.
> 	(build): Add logging.
> 	(check): Add logging.
> 	(install): Add logging.

And this:

	(conf,build,check,install): Add logging.

> 	(spkg): Compress logfiles.

Looks good otherwise.
Thanks for the patch and for putting up with me. :-)

As I said in my reply to Lapo, I'd rather have as few files in /usr/src as
possible -- once they are in the package-specific source directory, the
maintainers can do whatever they want.  So, would it make sense to add a
step that would uncompress the log files into the source directory (say,
in the prep() step)?  You can put them in the package root, or create a
"logs" subdirectory -- the structure is up to you.  I'd also include a
"NOLOGS" variable (or some other mechanism to turn off the logging for
those maintainers who don't want it).

I don't mean to be nitpicking here, but if we're doing this, let's do this
right.  I'd like to hear from people on what they feel is "right" in this
case.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]