This is the mail archive of the cygwin-apps mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: cygwin setup 2.510.2.1 does not work because of an invalid iterator.


----Original Message----
>From: M.Fujii
>Sent: 10 September 2005 03:29

> Hi.
> 
> # Excuse me my poor English.
> 
> I found the cause of crash on setup.exe 2.510.2.1 built by GCC 3.4.4.
> Please try an attached patch.
> 
> Calling erase() in packagemata::ScanDownloadedFiles() invalidates
> iterator i.
> Therefore, ++i after erase() means an operation to a invalid
> iterator. I guess it is the cause of a crash of setup.exe.
 

  A million thanks, Fujii-san!  Your analysis clearly makes sense, your
patch fixes the bug, and your English is very good!  :)  The change is very
small, so there will be no need for a copyright assignment; so please send a
ChangeLog entry and I or one of the others will apply it.


    cheers,
      DaveK
-- 
Can't think of a witty .sigline today....


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]