Re: Setup: hardlinks & percentages. (+patches)

["Max Bowsher" <maxb at ukf dot net>]

Bas van Gompel wrote:
> 2005-01-07  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
>
> * archive.cc (archive::extract_file): Use prefixPath for linktarget
> on hardlinks.
>
>
> --- setup/archive.cc 25 Dec 2004 23:05:56 -0000 2.10
> +++ setup/archive.cc 7 Jan 2005 20:39:42 -0000
> @@ -161,7 +161,7 @@ archive::extract_file (archive * source,
>  io_stream::remove (destfilename);
>  int ok =
>    io_stream::mklink (destfilename,
> -       prefixURL + source->linktarget (),
> +       prefixURL + prefixPath + source->linktarget (),
>       IO_STREAM_HARDLINK);
>  /* FIXME: check what tar's filelength is set to for hardlinks */
>  source->skip_file ();

I agree something is wrong here, but there are the following issues to 
consider:

A copy/paste of virtually the same code above deals with symlinks. 
Presumably that needs fixing too.

Also, might we need to handle relative and absolute linktarget paths 
differently here?


> 2005-01-07  Bas van Gompel  <patch-cygsup.buzz@bavag.tmfweb.nl>
>
> * ini.cc (class GuiParseFeedback): change type of lastpct.

Applied, thanks. (With slight changes to log message.)


Max.