This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Pending Packages List, 2004-01-30


I vote pro:

ploticus, otcl, tclcl, elinks, boxes

>Package: sgrep 1.92.1-1  [2003-09-15]
>Description: Search indexed text regions like SGML, XML and HTML files
>   Proposer: Jari Aalto
>   Proposal: http://sources.redhat.com/ml/cygwin-apps/2003-09/msg00166.html
>             http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1.tar.bz2
>             http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1-
>src.tar.bz2
>             http://tierra.dyndns.org:81/cygwin/sgrep/setup.hint
>     Status: Attained required 3 votes. Package available.
>   HOLD-UPS: No "good to go" review.

Good to go!

Package looks, works and builds fine.

Some minor observations for next release:

When running the package script, I get:

./sgrep-1.92.1-1.sh: line 547: [: -eq: unary operator expected
./sgrep-1.92.1-1.sh: line 547: [: -eq: unary operator expected

Recommend changing:

        if [ $count -eq 3 ]; then
to
        if [ "x$count" = "x3" ]; then

Also at the end of running "./sgrep-1.92.1-1.sh all" I see:

-- Making package [source] /tmp/cyg/sgrep-1.92.1-1-src.tar.bz2
./sgrep-1.92.1-1.sh: line 1: type: cygbuild.pl: not found
NOTE: To build a source package, install Cygbuild from
http://cygbuild.sourceforge.net/

But it does create a source package just fine.

Also, and this is a very minor quibble, would it be possible for the script to
gracefully die if run with "sh" rather than bash by accident?

-- 
Rafael



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]