Re: [Review - Not yet] suite3270

["Peter A. Castro" <doctor at fruitbat dot org>]

On Wed, 26 Nov 2003, Harold L Hunt II wrote:

> Peter,

Hi Harold,

> I just reviewed your suite3270 package.  Very nice work.  See review below.

Thanks for taking the time to review it!

> > Package: suite3270 3.2.20-1  [2003-11-15]
> > Description: 3270 Emulator Suite base package
> >    Proposer: Peter A. Castro
> >    Proposal: http://cygwin.com/ml/cygwin-apps/2003-11/msg00198.html
> >              http://www.fruitbat.org/Cygwin/suite3270/suite3270-3.2.20-1.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/suite3270-3.2.20-1-src.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/setup.hint.suite3270
> >        Also: pr3270  [3287 Printer Emulator]
> >              http://www.fruitbat.org/Cygwin/suite3270/pr3287-3.2.20-1.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/setup.hint.pr3287
> >        Also: s3270  [3270 Emulator (Scripted)]
> >              http://www.fruitbat.org/Cygwin/suite3270/s3270-3.2.20-1.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/setup.hint.s3270
> >        Also: tcl3270  [3270 Emulator (Tcl)]
> >              http://www.fruitbat.org/Cygwin/suite3270/tcl3270-3.2.20-1.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/setup.hint.tcl3270
> >        Also: x3270  [3270 Emulator (X-Windows)]
> >              http://www.fruitbat.org/Cygwin/suite3270/x3270-3.2.20-1.tar.bz2
> >              http://www.fruitbat.org/Cygwin/suite3270/setup.hint.x3270
> >   Aye votes: Igor Pechtchanski [1/3]
> >      Status: Package available.
> >    HOLD-UPS: Not enough votes (need 2 more). No "good to go" review.
>
> Problems
> ========
>
> 1) The "install" process complains:
>
> chmod: getting attributes of
> `/home/harold/ports/suite3270/x3270-3.2.20/.inst/usr/X11R6/lib/X11/fonts/misc/fonts.dir':
> No such file or directory
> make:
> [/home/harold/ports/suite3270/x3270-3.2.20/.inst/usr/X11R6/lib/X11/fonts/misc/fonts.dir]
> Error 1 (ignored)

Interesting.  This is part of the install rule in the x3270 Makefile and
is basically a kludge for handling a fonts.dir which might be read only.
This is done to deal with the scenario in which the product is being
built from scratch and installed to the local system directly, but which
might already have a fonts.dir which might be read-only.  Apparently Paul
(the creator of x3270) has encountered this problem before and this is a
work around for it.  For Cygwin the fonts.dir will not initially be
present, hence the Error 1, however it's a command that make can ignore
(-chmod) so, the warning can safely be ignored.  Here is the section of
offending makefile for your perusal:
----------8<------------------8<------------------8<-------------------
/* Extra install rule to regenerate fonts.dir. */
install:: $(DESTDIR)$(FONTINSTDIR)/fonts.dir
$(DESTDIR)$(FONTINSTDIR)/fonts.dir::
	-chmod u+w $(DESTDIR)$(FONTINSTDIR) $(DESTDIR)$(FONTINSTDIR)/fonts.dir
	$(MKFONTDIR) $(DESTDIR)$(FONTINSTDIR)
	chmod u=rwx,go=rx $(DESTDIR)$(FONTINSTDIR)
	chmod a=r $(DESTDIR)$(FONTINSTDIR)/fonts.dir
----------8<------------------8<------------------8<-------------------
Since this is the intended behaviour, and I don't want to make needless
changes to the makefile, I feel its acceptable.  I'm not intending to
"fix" this as it's works-as-designed.

> 2) The "all" command complains at the very end:
>
> ./make-c3270-standalone.sh: not found

This is curious.  Could you check a few things for me on your system to
help narrow down the problem (I can't seem to reproduce this error)?
Could you check the permissions of:

c3270-3.2.20/CYGWIN-PATCHES/standalone/make-c3270-standalone.sh
suite3270-3.2.20/promotecommon.sh

They should both be 775.  If they aren't what are they?
This could simply be an issue with how the files were created during the
patching does in the prep phase.
What's your current umask?
Do you have both /bin/sh and /bin/bash installed?

Lastly, could you try invoking it manually:

$ cd c3270-3.2.20/CYGWIN-PATCHES/standalone
$ ./make-c3270-standalone.sh /tmp/trash.zip

And if that doesn't run, try:

$ sh ./make-c3270-standalone.sh /tmp/trash.zip

Depending on the answers to the above, I'll tweak the code to correct for it.

> I will proceed with my review when these two problems have been addressed.

Thanks again!

> Harold

-- 
Peter A. Castro <doctor@fruitbat.org> or <Peter.Castro@oracle.com>
	"Cats are just autistic Dogs" -- Dr. Tony Attwood