This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [setup PATCH] Rework do_download [next_dialog removal (2b)]
- From: "Max Bowsher" <maxb at ukf dot net>
- To: "Robert Collins" <rbcollins at cygwin dot com>
- Cc: "Cygwin Apps" <cygwin-apps at cygwin dot com>
- Date: Tue, 30 Sep 2003 12:49:18 +0100
- Subject: Re: [setup PATCH] Rework do_download [next_dialog removal (2b)]
- References: <00f201c356e8$3a302120$5400a8c0@starfruit> <1064911879.759.9.camel@localhost>
Robert Collins wrote:
> On Thu, 2003-07-31 at 08:16, Max Bowsher wrote:
>> And another...
>
> This seems more complex than the previous code. You're moving window
> specific code from the specific class into the generic threebar class.
> This doesn't seem right to me.
I think the code I moved is better classified as program flow logic.
threebar.cc is already our main controller of program flow once the initial
few pages of settings are complete. At the moment, as individual window is
handling decisions on what to display next - *that* doesn't seem right to
me - it's exactly what wantsActivation was introduced to avoid.
I can agree that threebar.cc isn't the most elegant place to be handling
program flow, but that fact doesn't reduce the merits of tidying and
collecting program flow logic into a central location.
Max.