This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] SetDlgItemFont


Andrew M. Inggs wrote:
> Max Bowsher wrote:
>> Andrew M. Inggs wrote:
>>
>>> Could you include the ChangeLog on its own rather than using a
>>> diff-generated version?
>>
>> Why? The issue below? That's independent.

> It would make it easier to read, in my opinion.

I do strip off the diff surroundings, leaving only the + prefixed on each
line.

> It's also pretty standard policy to make it easier for the person
> applying the patch.  I guess it's not relevant here since you apply your
own.

Right. And if I were making patches for someone else to apply, I would
include the ChangeLog as a zero-context unidiff (-U0), which would add to
the top of ChangeLog regardless of it's contents.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]