This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Don't specify -Wmissing-declarations when compiling a C++ file


Robert Collins wrote:
> Max Bowsher wrote:
>> 2003-06-22  Max Bowsher  <maxb@ukf.net>
>>
>>         * Makefile.am (AM_CXXFLAGS): Remove -Wmissing-declarations, which
is
>> a
>>         C-only warning.
>
> Please check in.

The change makes a nearby comment much less obvious.
OK to check in with the following additional change?
-##AM_CFLAGS = -Werror -Wall -Winline -Wpointer-arith
+## We would like to use -Winline, but some STL code causes this warning.


Max.

Full patch:

Index: ChangeLog
===================================================================
RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/ChangeLog,v
retrieving revision 2.361
diff -u -p -r2.361 ChangeLog
--- ChangeLog 5 Jun 2003 15:35:51 -0000 2.361
+++ ChangeLog 22 Jun 2003 20:50:41 -0000
@@ -1,3 +1,8 @@
+2003-06-22  Max Bowsher  <maxb@ukf.net>
+
+ * Makefile.am (AM_CXXFLAGS): Remove -Wmissing-declarations, which is a
+ C-only warning.
+
 2003-06-05  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>

  * window.h (SETUP_WINDOW_H): Rename multi-include guard.
Index: Makefile.am
===================================================================
RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/Makefile.am,v
retrieving revision 2.29
diff -u -p -r2.29 Makefile.am
--- Makefile.am 29 Mar 2003 10:15:57 -0000 2.29
+++ Makefile.am 22 Jun 2003 20:06:01 -0000
@@ -24,11 +24,10 @@ SUBDIRS = bz2lib zlib libgetopt++ @RSYNC

 ## DISTCLEANFILES = include/stamp-h include/stamp-h[0-9]*

-AM_CFLAGS = -Werror -Wall -Wpointer-arith \
-  -Wcast-align -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \
-  -Wmissing-declarations -Wcomments
-AM_CXXFLAGS = $(AM_CFLAGS)
-##AM_CFLAGS = -Werror -Wall -Winline -Wpointer-arith
+## We would like to use -Winline, but some STL code causes this warning.
+AM_CXXFLAGS = -Werror -Wall -Wpointer-arith -Wcomments \
+  -Wcast-align -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
+AM_CFLAGS = $(AM_CXXFLAGS) -Wmissing-declarations

 WINDRES  := @WINDRES@



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]