This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 21 Mar 2003, Robert Collins wrote: > On Fri, 2003-03-21 at 04:49, Igor Pechtchanski wrote: > > > Same as above, but regenerated against HEAD. ChangeLog is the same. > > The only thing about this patch that really makes me uncomfortable is > > having to run through iterators/FindVisitors twice. Any suggestions for > > improvement are welcome. > > Sight unseen - instead of counting in the visitor and iterators, push > all the script details (and package references if appropriate) onto a > list or vector first time through. > > Then, simply walk the list. > Rob Fair enough. "Now, why didn't I think of that?"^TM A new iteration is attached. Igor ============================================================================== ChangeLog: 2003-03-20 Igor Pechtchanski <pechtcha at cs dot nyu dot edu> * threebar.h (WM_APP_START_POSTINSTALL): New message. (WM_APP_POSTINSTALL_THREAD_COMPLETE): New message. * threebar.cc (ThreeBarProgressPage::OnMessageApp): Add handling for WM_APP_START_POSTINSTALL and WM_APP_POSTINSTALL_THREAD_COMPLETE. * install.cc (do_install_thread): Set next_dialog to IDD_S_POSTINSTALL. * desktop.cc (DesktopSetupPage::OnFinish): Move the do_postinstall call to ThreeBarProgressPage::OnMessageApp. * postinstall.cc (Progress): New extern variable. (RunFindVisitor::visitFile): Add script to vector instead of running. (RunFindVisitor::_scripts): New member variable. (do_postinstall_thread): Rename do_postinstall to. Add Progress bar and text setting. Add package count. (do_postinstall_reflector): New static function. (do_postinstall): Rename to do_postinstall_thread. Create a thread instead. -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ pechtcha at cs dot nyu dot edu ZZZzz /,`.-'`' -. ;-;;,_ igor at watson dot ibm dot com |,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk! -- /usr/games/fortune
Attachment:
setup-postinstall-thread.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |