This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Cleanup: Close handles in script.cc:run()


The attached patch closes the unneeded handles in run() in script.cc.
Those handles should be closed according to
<http://msdn.microsoft.com/library/en-us/dllproc/base/createprocess.asp>:

lpProcessInformation
           [out] Pointer to a PROCESS_INFORMATION structure that receives
           identification information about the new process.

           Handles in PROCESS_INFORMATION must be closed with CloseHandle
           when they are no longer needed.

Feel free to reject if my understanding of the above is incorrect.
	Igor
==============================================================================
ChangeLog:
2003-03-15  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>

	* script.cc (run): Close unneeded handles.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune

Attachment: setup-script-close-handles.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]