Re: [PATCH] Fix iterator bug in choose.cc

[Robert Collins <rbcollins at cygwin dot com>]

On Fri, 2003-03-14 at 07:47, Igor Pechtchanski wrote:
> I noticed there is a bug in an iterator in choose.cc that causes "All" to
> be printed twice in the list of categories in setup.log.full.  The
> attached patch fixes that.  Note that, like the original, the patch will
> not work if a package is not in any category (but that shouldn't happen
> anyway, right?).
> 	Igor
> ==============================================================================
> 2003-03-13  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>
> 
> 	* choose.cc (ChooserPage::OnNext): Fix iterator bug.

Nice catch. Wouldn't
            = pkg.categories.begin ();
->          String all_categories = *(i++);

Be an easier fix?
-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part