This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Postinstall script ordering in setup - take 2


Attached is try #2.  This incorporates Rob's comments from
<http://cygwin.com/ml/cygwin-apps/2003-03/msg00041.html>.  I've also
refactored FileDesc to handle all dependence processing.

I think this would be good as a long-term solution as well.  As I
mentioned previously, I don't think we can use the existing package
dependence mechanism unless we also somehow track which package contains
which postinstall scripts.  Personally, I think storing dependences in the
postinstall scripts themselves is cleaner.  Opinions?
	Igor
==============================================================================
ChangeLog:
2003-03-03  Igor Pechtchanski <pechtcha at cs dot nyu dot edu>

	* postinstall.cc (RunFindVisitor::executeAll): New
	member function that propagates script dependences,
	topologically sorts the script list, and then executes
	the scripts (via other calls).
	(RunFindVisitor::visitFile): Change to add file to list
	instead of running it immediately.
	(RunFindVisitor::files): New member variable.
	(RunFindVisitor::checkAndLogMissingDependences): New
	member function.
	(FileDesc): New class that extracts and stores
	dependences from a script file.
	(DEPEND_STR): New #define.
	(do_postinstall): Add executeAll() call.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune

Attachment: setup-postinstall-ordering.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]