This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ITP] rebase


Ralf,

On Wed, Feb 12, 2003 at 01:48:09PM +0100, Ralf Habacker wrote:
> > Your guard:
> >
> >     (char *)relocp < (char *)relocs + size
> >
> > wasn't tight enough.
> >
> > My version:
> >
> >     (char *)&relocp->SizeOfBlock < (char *)relocs + size
> >
> > seems to be.
> >
> 
> What was the problem with this guard:

To which guard are you referring?  Mine or yours?

> Does it not fix the last entry of a relocation block ?

I'm concerned that my guard might have an off-by-one error and miss the
last entry.  Is there an easy way to check this?

Thanks,
Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]