This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full


On Sun, 2003-02-02 at 08:22, Max Bowsher wrote:
> Robert Collins wrote:
> > getFileName doesn't take a minlevel, it takes an exactLevel - your
> > parameter name is misleading, or you've got the logic in the loop
> > wrong :}.
> 
> Or, you could say that it gets the file whose minlevel is what you request.
> In which case its correct :-)

Huh? min stands for minimum. In the log context that makes sense, as you
are passed different levels of log entries. but for a search through the
log files?

It is misleading on first read, and thats the point.
perhaps 'minLevelOfLogFile' would be better.

> > IDS_MISSING_LOG should be "No log was in use", not "setup.log.full".
> > It'll be ugly in the output, but at least accurate.
> 
> "Check No log was in use for details."
> That's worse than what we have in CVS now.

No it's not, because the current setup code *always* uses a log file of
the appropriate level. It's a fallback to catch future changes.

> How about:

No. I like Igors approach better.
For yours, we end up with duplicate resources : you should split the
'installation incomplete' and the log to check into two separate
messages.
Secondly, you've still got getFile unrenamed. Let me clarify this point:
we have a structure for each file we are logging to. getFile should
return one of those structures - not the name of the file. However, as
we only care about the name today, getFileName will both not collide
with getFile, and be clear what it does from the header.
Lastly we should be looking at how we pull conditionals out of LogFile,
not inserting them.

Rob
-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]