Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full

["Max Bowsher" <maxb at ukf dot net>]

Igor Pechtchanski wrote:
> On Sat, 1 Feb 2003, Max Bowsher wrote:
>> What advantage do resources give us over string literals, for
>> messages that are only used once in setup?
>
> Resources have the advantage that whole resource tables can be
> substituted at once.  If we ever want to internationalize setup, for
> example, all
> that'd be needed is translating the resource file.  Having hard-coded
> string constants sprinkled all over the code makes translation
> impossible. Not that anyone has any plans to translate setup any time
> soon...  Again,
> I guess it's a question of programming style.

Fair enough. The thing I *really* hate, is that any change to resource.h,
and you end up recompiling *everything*.


Anyway...

I just tried it out, and was told "Check (null) for details".
I don't think you want to call cygpath at all. LogFile::getFile already
returns a Windows path.
(With rather ugly looking mixed slashes. backslash()-ing the path might be
nice.

One other point - it might be more informative for the fallback text to be
"setup.log.full" rather than "log file".


Max.