This is the mail archive of the
cygwin-apps@cygwin.com
mailing list for the Cygwin project.
Re: [setup PATCH] Remove pointless, worrying log message
- From: Christopher Faylor <cgf at redhat dot com>
- To: cygwin-apps at cygwin dot com
- Date: Sun, 19 Jan 2003 12:09:36 -0500
- Subject: Re: [setup PATCH] Remove pointless, worrying log message
- References: <00c801c2bfcf$0d4e83a0$78d96f83@pomello>
- Reply-to: cygwin-apps at cygwin dot com
On Sun, Jan 19, 2003 at 03:25:52PM -0000, Max Bowsher wrote:
>Index: compress_bz.cc
>===================================================================
>RCS file: /home/max/cvsmirror/cygwin-apps-cvs/setup/compress_bz.cc,v
>retrieving revision 2.7
>diff -u -r2.7 compress_bz.cc
>--- compress_bz.cc 10 Nov 2002 03:35:06 -0000 2.7
>+++ compress_bz.cc 19 Jan 2003 15:21:14 -0000
>@@ -194,7 +194,6 @@
> int
> compress_bz::error ()
> {
>- log (LOG_TIMESTAMP, "compress_bz::error called");
> return 0;
> }
>
>Code calls compress_bz::error() to ask *whether* an error has occurred. It
>is silly and scare-mongering to print "compress_bz::error called" to the log
>in this case.
>
>Ok to commit?
I don't want to override Rob here, but IMO that's a big YES.
cgf