This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Doxygen

> 1) The hunk starting at line 10474 of the patch is unnecessary
> 
> 2) The hunk starting at line 10479 seems unnecessary too - you don't
> link against the included libpng.

diff -Nrup doxygen-1.2.18/lib/st003592 doxygen-1.2.18-1/lib/st003592
diff -Nrup doxygen-1.2.18/libpng/libpng.pro doxygen-1.2.18-1/libpng/libpng.pro

I changed Makefile. "make distclean" remove st003592 & libpng.pro

> 3) I'm not quite sure but it seems like you made the patch against some
> already patched version of doxygen-1.2.18 and not the original one.

It is original one, not patched version.
Original one includes some needless files, so I removed.
"./configure" generates these files.
I think original one lack "make dist clean".

> 4) You used the '-fno-exceptions -fno-rtti' flags only in the Makefile
> responsible for building libdoxygen.a, while it can be used also in
> libdoxycfg.pro.in, doxygen.pro.in, doxygen.pro.in, doxysearch.pro.in,
> doxytag.pro.in and qtools.pro.in.A

Fixed.

Thanks for your review.

Updated.
http://www.geocities.co.jp/SiliconValley-SanJose/5153/cygwin-package/doxygen-1.2.18-1-package.tgz
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]