This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Improve Category column (Take 2)


Max Bowsher wrote:
> Robert Collins wrote:
> > Much better. Please supply as a attachment, along with a changelog.

Here.

> > > +  set<String, String::caseless>::const_iterator all =
> categories.find("All");
> > this is also not needed, and if we were using something that supports
> > multiple entries (say a vector) with the same key, would give incorrect
> > results.
>
> My gut feeling was that an iterator should compare quicker than a string.

I did some speed testing - I was wrong, it turns out.

It turns out that my weird attempt at making thinks faster actually made things
_slower_. The patch is therefore remodelled.

Max.

Attachment: ChangeLog-fragment
Description: Binary data

Attachment: setup-categories.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]