Re: [setup PATCH] Fix DEBUG mode in IniDBBuilderPackage, andimproveCategory column contents.

[Robert Collins <rbcollins at cygwin dot com>]

On Thu, 2002-09-19 at 22:20, Max Bowsher wrote:
> Robert Collins wrote:
> > On Thu, 2002-09-19 at 21:29, Max Bowsher wrote:
> > > Here is a patch for setup.
> > >
> > > IniDBBuilderPackage.cc: Fix DEBUG mode
> > > Hunk 1: Remove a DEBUG message box which otherwise pops up once per package
> > > during ini parsing, thus rendering DEBUG unusable.
> >
> > This stays for now. It's there because it was needed, and I don't think
> > that has changed yet.
> 
> I'm not that bothered, I can easily delete 3 lines at the same time as I add
> "#define DEBUG 1", but seriously, have you ever actually clicked OK 171 times to
> proceed through all the ldescs in setup.ini ?

Yes. through 8000 packages in fact. I had some nasty escaping problems.
> packagemeta::categories is defined directly as a set <String, String::caseless>.

> Are you saying that I should create a categorylisttype type? Or can I just use
> set<String, String::caseless>::const_iterator?

You can do either. set<> is less changes. If this was not going to be a
method, I'd say create the type. As it is, it doesn't really matter.

Rob

Attachment: signature.asc
Description: This is a digitally signed message part