This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH suggestion] Can't open null for reading when installing from local directory


----- Original Message -----
From: "Pavel Tsekov" <ptsekov@syntrex.com>
To: <cygwin-apps@cygwin.com>
Sent: Wednesday, July 03, 2002 10:39 PM
Subject: [PATCH suggestion] Can't open null for reading when installing from
local directory


> The following code is wrong - choose.cc, default_trust ():
...
> This results in the nasty message being showed later in install.cc:

Good catch. It's a -bit- of a corner case, as setup will always default to
downloading those packages in the first place. The HEAD and setup-200207
equivalent is packageversion.accessible() which encapsulates all knowledge
about mirror sites, cached files and so on.

packagemeta already has such protection (from memory).

...
> This patch is against 2.249.2.4 - I haven't verified if the problem is
> still in the latest snapshot.

It was. Inserting 'pkg.desired.accessible() &&'  into the if clause handles
it. I'm committing such a patch to HEAD and setup-200207.

Thanks,
Rob



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]