Re: aalib-1.4.0 ready for review/upload [was: Re: [ITP]: aalib-1.4.0]

[Charles Wilson <cwilson at ece dot gatech dot edu>]

Nicholas Wourms wrote:

> Although this is mostly a console application library, there are some X
> applications which use it, so I have also linked against the X11 runtime
> library. 

Then this should be (eventually) installed on sourceware under 
release/XFree86/ per current standard.

Also, it should be compiled with --prefix=/usr/X11R6/, and the actual 
"accept/no-accept" decision will probably be made on the cygwin-xfree 
list, with Harold as final arbiter, not cgf.

Right?

Perhaps you want two different sets:
 aalibX  --prefix=/usr/X11R6/
 libaaX0 --prefix=/usr/X11R6/
 aalib   --prefix=/usr (NO dependency on X stuff)
 libaa0  --prefix=/usr (ditto)


> There were some variables which were auto-imported at
> link-time, but they don't seem to be causing any issues, as the tests
> work fine.

No need to fear auto-import.  Current binutils will fail during the link 
with an error, when the variable access is done "wrong":
     "variable '<var>' can't be auto-imported. Please read the
     documentation for ld's `--enable-auto-import' for details."
If you didn't see the error (e.g. you linked successfully) then you 
needn't worry.


>  Note that I also generated the source tarball from CVS
> sources, due to the fact that I found fixes in the CVS that I liked and
> the fact that the latest releases were all release candidtates.

In that case, your package version should be YYYYMMDD of the date you 
checked out the sources.


>  The
> problem was they were all 1 year old!  The author is at-large, so future
> development on this project may be slow.  Finally, I have included both
> static and shared libraries, so if you prefer static, besure to link
> with the -static flag when using gcc.  I have attached the readme for
> your reference.  For a sample of what this library can do, go to:
>
> http://aa-project.sourceforge.net/gallery/holecek.html
>
> Here is where to get the packages:
> http://today.clemson.edu/cygwin/release/aalib/setup.hint
> http://today.clemson.edu/cygwin/release/aalib/aalib-1.4.0-1.tar.bz2
> http://today.clemson.edu/cygwin/release/aalib/aalib-1.4.0-1-src.tar.bz2
> http://today.clemson.edu/cygwin/release/aalib/libaa0/setup.hint
> http://today.clemson.edu/cygwin/release/aalib/libaa0/libaa0-1.4.0-1.tar.bz2
>
> Here are the setup.hints:

Looks fine to me, otherwise.  I give this a +1 (provided the above 
changes are made).

--Chuck