RE: Re[2]: Patch for Setup.exe problem and for mklink2.cc

["Robert Collins" <robert dot collins at itdomain dot com dot au>]

> -----Original Message-----
> From: Pavel Tsekov [mailto:ptsekov@syntrex.com] 
> Sent: Friday, March 29, 2002 8:42 PM
> To: Robert Collins
> Cc: cygwin-apps@cygwin.com
> Subject: Re[2]: Patch for Setup.exe problem and for mklink2.cc
> 
> 
> Hello Robert,
> 
> Friday, March 29, 2002, 10:25:08 AM, you wrote:
> 
> >> > Found the problem causing the segment violation and probably 
> >> > causing Jonas Eriksson's problem. It is a typical case 
> of 'off by 
> >> > 1'. In PickView::set_headers the loop filling the window header 
> >> > does one iteration too much, resulting in a call to DoInsertItem 
> >> > with a NULL string pointer and hence a crash following. While 
> >> > debugging this I could not compile the new mklink2.cc ( the
> >> > c++ version of the original mklink2.c). It seems three & 
> (address 
> >> > c++ of
> >> > c++ operator)
> >> > have disappeared in the transition. Putting them back made the 
> >> > compiler happy. Is this OK Robert ?
> >> 
> >> I'll check the off-by-one fix in tomorrow, as I'm off to bed now.
> 
> RC> Actually, this is not an off-by-one error. It's an invalid data 
> RC> error - the loop is meant to go from 0 to == last_col, where last 
> RC> col is meant to be equal to the greatest column number. The first 
> RC> set of column details had last_col set incorrectly.
> 
> Btw I don't think my question is related to this is issue but 
> still... I notice there is a dummy column in the list view 
> after the "Package" column - is this a feature ? If so what 
> is its purpose ?

There shouldn't be - but HEAD doesn't have the fix for the data yet, you
might try the released setup.exe and see if it looks the same to you.

Rob